Skip to content

Backport of NET-5186 Add NET_BIND_SERVICE to built-in PSPs for consul-dataplane deployments into release/1.0.x#2899

Merged
nathancoleman merged 1 commit intorelease/1.0.xfrom
backport/dataplane-psps/locally-magnetic-narwhal
Sep 5, 2023
Merged

Backport of NET-5186 Add NET_BIND_SERVICE to built-in PSPs for consul-dataplane deployments into release/1.0.x#2899
nathancoleman merged 1 commit intorelease/1.0.xfrom
backport/dataplane-psps/locally-magnetic-narwhal

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

@hc-github-team-consul-core hc-github-team-consul-core commented Sep 5, 2023

Backport

This PR is auto-generated from #2890 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:
PodSecurityPolicy needs to add the NET_BIND_SERVICE capability for any Deployment that includes consul-dataplane.

A search for these in the consul-k8s repo yields:
CleanShot 2023-09-01 at 16 25 06@2x

How I've tested this PR:

  1. Create a GKE cluster with PodSecurityPolicy enforcement enabled
$ gcloud beta container clusters create cluster-1 --cluster-version=1.24 --enable-pod-security-policy
  1. Deploy Consul with PodSecurityPolicy enabled as well as the various gateway types and the telemetry collector
global:
  enablePodSecurityPolicies: true
telemetryCollector:
  enabled: true
meshGateway:
  enabled: true
terminatingGateways:
  enabled: true
ingressGateways:
  enabled: true
  gateways:
  - name: ingress-gateway
    service:
      type: LoadBalancer
      ports:
      - port: 80
  1. Verify that dataplane container in ingress-gateway, mesh-gateway, terminating-gateway and telemetry-collector pods successfully starts up. A failure scenario looks like exec /usr/local/bin/consul-dataplane: operation not permitted.

How I expect reviewers to test this PR:

Checklist:


Overview of commits

@hashicorp-cla
Copy link
Copy Markdown

hashicorp-cla commented Sep 5, 2023

CLA assistant check
All committers have signed the CLA.

…-dataplane deployments

Add NET_BIND_SERVICE to built-in PSPs for consul-dataplane deployments
@nathancoleman nathancoleman force-pushed the backport/dataplane-psps/locally-magnetic-narwhal branch from a3d27bc to aba03b6 Compare September 5, 2023 16:54
@nathancoleman nathancoleman marked this pull request as ready for review September 5, 2023 16:59
Copy link
Copy Markdown
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches source PR except for the telemetry collector which doesn't exist in this version

@nathancoleman nathancoleman merged commit 989beb4 into release/1.0.x Sep 5, 2023
@nathancoleman nathancoleman deleted the backport/dataplane-psps/locally-magnetic-narwhal branch September 5, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants