NET-5186 Add NET_BIND_SERVICE to built-in PSPs for consul-dataplane deployments#2890
Merged
nathancoleman merged 1 commit intomainfrom Sep 5, 2023
Merged
NET-5186 Add NET_BIND_SERVICE to built-in PSPs for consul-dataplane deployments#2890nathancoleman merged 1 commit intomainfrom
nathancoleman merged 1 commit intomainfrom
Conversation
andrewstucki
approved these changes
Sep 1, 2023
david-yu
approved these changes
Sep 1, 2023
This was referenced Sep 5, 2023
Member
Author
|
Not including changelog here since this PR is just picking up something I missed in #2787 , which did include a changelog entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
PodSecurityPolicy needs to add the
NET_BIND_SERVICEcapability for any Deployment that includes consul-dataplane.A search for these in the consul-k8s repo yields:

How I've tested this PR:
exec /usr/local/bin/consul-dataplane: operation not permitted.How I expect reviewers to test this PR:
Checklist: