Skip to content

Backport of add 365 days instead of 1 year to account for leap years into release/1.0.x#1972

Merged
hc-github-team-consul-core merged 1 commit intorelease/1.0.xfrom
backport/fix-leap-year-test/notably-fleet-flamingo
Mar 2, 2023
Merged

Backport of add 365 days instead of 1 year to account for leap years into release/1.0.x#1972
hc-github-team-consul-core merged 1 commit intorelease/1.0.xfrom
backport/fix-leap-year-test/notably-fleet-flamingo

Conversation

@hc-github-team-consul-core
Copy link
Copy Markdown
Collaborator

Backport

This PR is auto-generated from #1969 to be assessed for backporting due to the inclusion of the label backport/1.0.x.

The below text is copied from the body of the original PR.


Changes proposed in this PR:

  • There was an issue where adding 1 year to the time check would fail if it was March 1st because the certificate would be expired Feb 29th. Fixed test to use 365 day increment instead of 1 year increment.

How I've tested this PR:
👀

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/fix-leap-year-test/notably-fleet-flamingo branch from fda2c03 to 46d7977 Compare March 2, 2023 16:30
@hc-github-team-consul-core hc-github-team-consul-core merged commit 5c7a02d into release/1.0.x Mar 2, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/fix-leap-year-test/notably-fleet-flamingo branch March 2, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant