Skip to content

add 365 days instead of 1 year to account for leap years#1969

Merged
wilkermichael merged 1 commit intomainfrom
fix-leap-year-test
Mar 2, 2023
Merged

add 365 days instead of 1 year to account for leap years#1969
wilkermichael merged 1 commit intomainfrom
fix-leap-year-test

Conversation

@wilkermichael
Copy link
Copy Markdown
Contributor

Changes proposed in this PR:

  • There was an issue where adding 1 year to the time check would fail if it was March 1st because the certificate would be expired Feb 29th. Fixed test to use 365 day increment instead of 1 year increment.

How I've tested this PR:
👀

How I expect reviewers to test this PR:
👀

Checklist:

  • Tests added
  • [n/a] CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@wilkermichael wilkermichael added the pr/no-changelog PR does not need a corresponding .changelog entry label Mar 1, 2023
@wilkermichael wilkermichael requested review from a team, curtbushko and kyhavlov and removed request for a team March 1, 2023 23:25
@wilkermichael wilkermichael added backport/0.49.x backport/1.1.x Backport to release/1.1.x branch labels Mar 1, 2023
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Such a weird bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.1.x Backport to release/1.1.x branch pr/no-changelog PR does not need a corresponding .changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants