Allow to apply additional labels to the connect inject pods#1678
Merged
thisisnotashwin merged 1 commit intohashicorp:mainfrom Nov 11, 2022
ilpianista:feature/consul-inject-extraLabels
Merged
Allow to apply additional labels to the connect inject pods#1678thisisnotashwin merged 1 commit intohashicorp:mainfrom ilpianista:feature/consul-inject-extraLabels
thisisnotashwin merged 1 commit intohashicorp:mainfrom
ilpianista:feature/consul-inject-extraLabels
Conversation
Contributor
|
Thank you, this looks great we will take a look! |
thisisnotashwin
approved these changes
Nov 9, 2022
Contributor
thisisnotashwin
left a comment
thisisnotashwin
left a comment
There was a problem hiding this comment.
Thanks so much for the contribution!!
thisisnotashwin
requested review from
a team,
curtbushko and
ishustava
and removed request for
a team
curtbushko
approved these changes
Nov 9, 2022
Contributor
curtbushko
left a comment
curtbushko
left a comment
There was a problem hiding this comment.
This looks great! Thank you for your contribution! It is very much appreciated!
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
We run this in our production.
How I expect reviewers to test this PR:
I've added a unit tests.
Checklist: