Add extraLabels to connectInject and serverACLInit pods#1380
Closed
s-andresen wants to merge 3 commits intohashicorp:mainfrom
Closed
Add extraLabels to connectInject and serverACLInit pods#1380s-andresen wants to merge 3 commits intohashicorp:mainfrom
s-andresen wants to merge 3 commits intohashicorp:mainfrom
Conversation
Add extraLabels to connectInject pods and to serverACLInit pod to values
Add extraLabels if extraLabels are defined in the values file
Add extraLabels to serverACLInit pod if declared in values
|
|
s-andresen
changed the title
Contributor
|
@s-andresen Could you tell us whether you expect to apply the same labels for both components? We had a similar PR previously but opted for an approach to create a label for all components for a global label instead. |
lkysow
suggested changes
Aug 18, 2022
Contributor
lkysow
left a comment
lkysow
left a comment
There was a problem hiding this comment.
Looking good, but can you please add bats tests? You should be able to follow the pattern for other extraLabels tests.
| tests: | ||
| enabled: true | ||
|
|
||
| serverACLInit: |
Contributor
There was a problem hiding this comment.
Let's put this under global.acls.serverACLInit?
Contributor
|
Closing in favor of #1678, could you open a separate PR That enables ServerACLInit with bats test included? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Added extraLabels to connectInject and serverACLInit in values.yaml so if declared in the values file then these additional labels will be added to the pods
How I've tested this PR:
Tested the helm chart on my kubernetes cluster with and without declaring the extraLabels to ensure everything works as expected.
How I expect reviewers to test this PR:
Same as how I tested
Checklist: