Skip to content

Backport of Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager into release/0.49.x#1626

Merged
hc-github-team-consul-ecosystem merged 10 commits intorelease/0.49.xfrom
backport/add-nodeSelector/actually-pet-glider
Oct 18, 2022
Merged

Backport of Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager into release/0.49.x#1626
hc-github-team-consul-ecosystem merged 10 commits intorelease/0.49.xfrom
backport/add-nodeSelector/actually-pet-glider

Conversation

@hc-github-team-consul-ecosystem
Copy link
Copy Markdown
Contributor

Backport

This PR is auto-generated from #1581 to be assessed for backporting due to the inclusion of the label backport/0.49.x.

The below text is copied from the body of the original PR.


This solution is in response to an ask from a customer who wants to set nodeSelector for all Pods in their cluster. This adds that capability to server-acl-init jobs and webhook-cert-manager.

Changes proposed in this PR:

  • Add a Helm stanza, global.acls.job for configuring server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value global.acls.job.tolerations for setting tolerations on server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value global.acls.job.nodeSelector for setting the nodeSelector on server-acl-init and server-acl-init-cleanup jobs.
  • Add the Helm value webhookCertManager.nodeSelector for setting the nodeSelector on webhook-cert-manager-deployment.
  • Add BATS tests for all of the above changes.

How I've tested this PR:

  • I deployed the following Helm values into an AKS account to ensure that Consul runs normally when server-acl-init and webhook-cert-manager are deployed on a particular node. There is no anticipated reason why they shouldn't.

How I expect reviewers to test this PR:

  • 👀
  • Run a Helm chart that sets nodeSelector.

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)


Overview of commits

@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem force-pushed the backport/add-nodeSelector/actually-pet-glider branch from d3de8e1 to 8e2b080 Compare October 18, 2022 17:47
@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem merged commit 4f4a989 into release/0.49.x Oct 18, 2022
@hc-github-team-consul-ecosystem hc-github-team-consul-ecosystem deleted the backport/add-nodeSelector/actually-pet-glider branch October 18, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant