Backport of Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager into release/0.49.x#1626
Merged
hc-github-team-consul-ecosystem merged 10 commits intorelease/0.49.xfrom Oct 18, 2022
Conversation
added 10 commits
October 3, 2022 16:10
d3de8e1 to
8e2b080
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #1581 to be assessed for backporting due to the inclusion of the label backport/0.49.x.
The below text is copied from the body of the original PR.
This solution is in response to an ask from a customer who wants to set
nodeSelectorfor all Pods in their cluster. This adds that capability toserver-acl-initjobs andwebhook-cert-manager.Changes proposed in this PR:
global.acls.jobfor configuringserver-acl-initandserver-acl-init-cleanupjobs.global.acls.job.tolerationsfor setting tolerations onserver-acl-initandserver-acl-init-cleanupjobs.global.acls.job.nodeSelectorfor setting the nodeSelector onserver-acl-initandserver-acl-init-cleanupjobs.webhookCertManager.nodeSelectorfor setting the nodeSelector onwebhook-cert-manager-deployment.How I've tested this PR:
server-acl-initandwebhook-cert-managerare deployed on a particular node. There is no anticipated reason why they shouldn't.How I expect reviewers to test this PR:
nodeSelector.Checklist:
Overview of commits