Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager#1581
Merged
Add tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager#1581
tolerations and nodeSelector to Server ACL init jobs and nodeSelector to Webhook cert manager#1581Conversation
added 5 commits
October 3, 2022 12:10
t-eckert
force-pushed
the
add-nodeSelector
branch
from
cbb828b to
4f9b49c
Compare
t-eckert
commented
Oct 3, 2022
ishustava
reviewed
Oct 14, 2022
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Looks good, just one comment about helm values.
ishustava
reviewed
Oct 14, 2022
Contributor
ishustava
left a comment
ishustava
left a comment
There was a problem hiding this comment.
Sorry! A few more comments. I didn't notice these in my first review
Co-authored-by: Iryna Shustava <ishustava@users.noreply.github.com>
ishustava
approved these changes
Oct 15, 2022
2 tasks
2 tasks
2 tasks
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solution is in response to an ask from a customer who wants to set
nodeSelectorfor all Pods in their cluster. This adds that capability toserver-acl-initjobs andwebhook-cert-manager.Changes proposed in this PR:
global.acls.jobfor configuringserver-acl-initandserver-acl-init-cleanupjobs.global.acls.job.tolerationsfor setting tolerations onserver-acl-initandserver-acl-init-cleanupjobs.global.acls.job.nodeSelectorfor setting the nodeSelector onserver-acl-initandserver-acl-init-cleanupjobs.webhookCertManager.nodeSelectorfor setting the nodeSelector onwebhook-cert-manager-deployment.How I've tested this PR:
server-acl-initandwebhook-cert-managerare deployed on a particular node. There is no anticipated reason why they shouldn't.How I expect reviewers to test this PR:
nodeSelector.Checklist: