Skip to content
This repository was archived by the owner on Mar 19, 2024. It is now read-only.

Fix intention syncing CAS index#308

Merged
andrewstucki merged 2 commits intomainfrom
fix-intention-syncing
Aug 15, 2022
Merged

Fix intention syncing CAS index#308
andrewstucki merged 2 commits intomainfrom
fix-intention-syncing

Conversation

@andrewstucki
Copy link
Copy Markdown
Contributor

@andrewstucki andrewstucki commented Aug 15, 2022

Changes proposed in this PR:

Our CAS operation for updating intentions was broken because it was using the wrong config entry index. The result is that if multiple gateways bound to a single service then intentions for the second gateway weren't being properly created. This changes the sync code to use the proper index.

How I've tested this PR:

Manually and updated tests.

Checklist:

  • Tests added
  • CHANGELOG entry added

    Run make changelog-entry for guidance in authoring a changelog entry, and
    commit the resulting file, which should have a name matching your PR number.
    Entries should use imperative present tense (e.g. Add support for...)

@andrewstucki andrewstucki requested a review from a team August 15, 2022 19:43
@nathancoleman
Copy link
Copy Markdown
Member

Tested by setting a breakpoint on the modified assertion in k8s_e2e_test.go. Without this change, only one intention is created, and the second fails. With this change, both intentions are successfully created.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants