This repository was archived by the owner on Mar 19, 2024. It is now read-only.
ci: add Consul v1.13 and 1.14-dev edge builds to test matrices#307
Merged
nathancoleman merged 4 commits intomainfrom Aug 15, 2022
Merged
ci: add Consul v1.13 and 1.14-dev edge builds to test matrices#307nathancoleman merged 4 commits intomainfrom
nathancoleman merged 4 commits intomainfrom
Conversation
mikemorris
added
pr/no-changelog
mikemorris
force-pushed
the
ci/consul-v1.13
branch
from
b5f0473 to
341fcbe
Compare
mikemorris
removed
the
pr/no-changelog
nathancoleman
changed the title
…an HTTPRoute to multiple gateways
nathancoleman
force-pushed
the
ci/consul-v1.13
branch
from
0e167ea to
797f234
Compare
nathancoleman
added
the
pr/no-changelog
Contributor
Author
|
The underlying issue causing an assertion in the e2e tests to fail with Consul v1.13 has been fixed in #308 |
andrewstucki
approved these changes
Aug 15, 2022
nathancoleman
approved these changes
Aug 15, 2022
Comment on lines
+47
to
+51
| - name: "consul@v1.14-dev + consul-k8s@v0.47.1" | ||
| api-gateway-image: "hashicorppreview/consul-api-gateway:0.4-dev" | ||
| consul-image: "hashicorppreview/consul:1.14-dev" | ||
| envoy-image: "envoyproxy/envoy:v1.22-latest" | ||
| consul-k8s-version: "v0.47.1" |
Member
There was a problem hiding this comment.
I think it's helpful to add these, but I imagine we're going to reach a point where 1.14 depends on some not-yet-released change in consul-k8s. At that point we'll just need to consume consul-k8s-version: "main"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
Refs #303 (comment)
How I've tested this PR:
Running CI unit, e2e and conformance tests for all supported versions.
How I expect reviewers to test this PR:
Confirm that mitigations for new behavior are understood and acceptable. Do we want to check upstream Consul core per-commit builds in regular CI, or only nightly conformance?
Checklist:
CHANGELOG entry added