This repository was archived by the owner on Mar 19, 2024. It is now read-only.
Merged
Conversation
CVE-2020-29509 and CVE-2020-29511 do not currently have a fix available and are used in test code. The long-term plan is an allow-list to ignore particular CVEs that don't have a functional impact on the product that we're shipping; however, that allow list doesn't currently exist. At the recommendation of ProdSec, I'm disabling NVD scanning on our binary similar to other repos that have encountered the same two CVEs: https://github.com/search?q=org%3Ahashicorp+Turn+nvd+security+scanning+off+temporarily&type=issues
nathancoleman
added
the
pr/no-changelog
Member
Author
|
This is followup to #206 |
mdeggies
approved these changes
Jun 8, 2022
nathancoleman
added a commit
that referenced
this pull request
Jun 9, 2022
CVE-2020-29509 and CVE-2020-29511 do not currently have a fix available and are used in test code. The long-term plan is an allow-list to ignore particular CVEs that don't have a functional impact on the product that we're shipping; however, that allow list doesn't currently exist. At the recommendation of ProdSec, I'm disabling NVD scanning on our binary similar to other repos that have encountered the same two CVEs: https://github.com/search?q=org%3Ahashicorp+Turn+nvd+security+scanning+off+temporarily&type=issues
nathancoleman
added a commit
that referenced
this pull request
Jun 9, 2022
CVE-2020-29509 and CVE-2020-29511 do not currently have a fix available and are used in test code. The long-term plan is an allow-list to ignore particular CVEs that don't have a functional impact on the product that we're shipping; however, that allow list doesn't currently exist. At the recommendation of ProdSec, I'm disabling NVD scanning on our binary similar to other repos that have encountered the same two CVEs: https://github.com/search?q=org%3Ahashicorp+Turn+nvd+security+scanning+off+temporarily&type=issues
This was referenced Jun 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CVE-2020-29509 and CVE-2020-29511 do not currently have a fix available and are used only in test code.
$ go mod why encoding/xml # encoding/xml github.com/hashicorp/consul-api-gateway/internal/testing math/big math/big.test encoding/xmlThe long-term plan is an allow-list to ignore particular CVEs that don't have a functional impact on the product that we're shipping; however, that allow list doesn't currently exist. ProdSec has an outstanding issue for addressing this.
At the recommendation of ProdSec, I'm disabling NVD scanning on our binary similar to other repos that have encountered the same issue. There will be followup work to set this back to
trueonce the long-term solution is in place.Changes proposed in this PR:
Set
nvd=falsein our release scanning configHow I've tested this PR:
Discussed change with ProdSec and mirrored other repos having the same issues
How I expect reviewers to test this PR:
Check into the links above to verify my paper trail
Checklist: