Trigger CRT workflows for main branch#206
Conversation
sarahalsmiller
left a comment
There was a problem hiding this comment.
Does it matter that the -dev tag will still be applied to preview builds in our release branches? Otherwise looks fine to me.
|
I don't think it particularly matters, but it might get kinda gross. I might leave as-is for release branches and fork to publish That way each release branch is publishing it's version, but we aren't publishing from main branch as |
|
The consul PR was recently updated. Just want clarify the names of tags as the PR currently stands-- PR's merged to
On merges to |
|
Whoops, I hit send too quickly. We need to document this better, but dropping the patch version from the release branches is an option. The tags from release branches will then be |
There was a problem hiding this comment.
LGTM with caveat that we may want to tweak the dev tag format slightly. +1 to doing something different with the main branch so we don't end up with a misleading tag name (having 0.2.1-dev represent potential 0.3.0 prerelease work while 0.2-dev accurately represents an upcoming 0.2.2 release feels undesirable), not sure if there's any existing convention around just like a plain dev and dev-$GITSHA tag instead of something verbose/redundant like main-latest?
.github/workflows/build.yml
Outdated
| docker.io/hashicorppreview/${{env.repo}}:${{env.version}}-dev | ||
| docker.io/hashicorppreview/${{env.repo}}:${{env.version}}-dev-${{github.sha}} |
There was a problem hiding this comment.
Could we slice off the patch segment so this is just MAJOR.MINOR-dev to reflect the intended change in hashicorp/consul#13308?
There was a problem hiding this comment.
I love this idea; however, my focus this PR is just getting the main branch published to unblock other work.
Mind if we circle back with a targeted PR to change how we're tagging for release/* branches?
|
@mdeggies Should we consider keeping |
|
I've differentiated the main branch
The above all require that we change our workflow a little to update
|
|
Discussed with @mdeggies a bit ago and have a plan for additional changes to fit RelEng's new guidelines. The main part will be a workflow change for our team. More to come, but draft for now |
Changes proposed in this PR:
mainto the list of branches that trigger Common Release Tooling workflows. This will produce thedev_tagsimages of consul-api-gateway defined here onto hashicorppreview whenever we push commits tomain. Matches what Consul is doing here.mainwon't interrupt our daily conversations.dev_tagsso that we can always test with a specific image even after newer versions have been published. I used the naming patterns from Consul's hashicorppreview repo here.version.goto reflect our next release,0.3.0, so that dev tags reflect the in-progress work correctlyHow I've tested this PR:
There's not a good way to test this change without having the modified actions file merged into
main, but the stakes are very low since we're only modifying our own internal process.How I expect reviewers to test this PR:
Checklist: