Switch Redirect storage SessionStorage to LocalStorage #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreda
approved these changes
Mar 23, 2023
There was a problem hiding this comment.
We discussed this offline, but just to put it here too - I think this is worth trying to see if it fixes the current issue where redirects aren't preserved in some cases. It's probably not the best way to handle this (the 2 minute expiration sorta-hack), but could be a beneficial interim solution.
|
Working on a PR that prefers sessionStorage but falls back to localStorage. Update: #103 |
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…ge#94) * Switch from SessionStorage to LocalStorage * Use expiring localStorage * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the user's redirectIntent from SessionStorage to LocalStorage, where it can survive a cross-origin transition. Sets a 2-minute expiration on the cookie to prevent old redirectIntents from sticking around.