Combine Session and LocalStorage for redirect handling #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
force-pushed
the
jeffdaley/move-local-storage-to-fallback
branch
2 times, most recently
from
c65b91c
to
5c26e64
Compare
jeffdaley
force-pushed
the
jeffdaley/move-local-storage-to-fallback
branch
from
5c26e64
to
c544ec8
Compare
jeffdaley
changed the title
jfreda
approved these changes
Mar 30, 2023
jeffdaley
force-pushed
the
jeffdaley/move-local-storage-to-fallback
branch
from
d1531ca
to
e606129
Compare
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
…ge#103) * Switch from SessionStorage to LocalStorage * Use expiring localStorage * Add test * Make localStorage a fallback * Remove MockDate; Switch to afterEach * Increase expiration time * Fix expiration logic; Cleanup * Update session-test.ts * Tweak isObject; Add documentation * Update test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up to #94 (and response to @jfreda's comment),
this adds localStorage as a fallback redirect solution rather the primary one.
Still need to figure out why SessionStorage doesn't work on the first try...