Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProductBadge query value #305

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix ProductBadge query value #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0498b6
Reset queryParams on ProductBadge click
jeffdaley Aug 24, 2023
cc75e04
Add todo test
jeffdaley Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions web/app/components/product-badge-link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ export default class ProductBadgeLinkComponent extends Component<ProductBadgeLin
if (this.args.productArea) {
return {
product: [this.args.productArea],
docType: [],
owners: [],
page: 1,
sortBy: "dateDesc",
status: [],
};
} else {
return {};
Expand Down
12 changes: 12 additions & 0 deletions web/tests/acceptance/authenticated/all-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,16 @@ module("Acceptance | authenticated/all", function (hooks) {
.dom(PRODUCT_BADGE_LINK_SELECTOR)
.hasAttribute("href", "/all?product=%5B%22Labs%22%5D");
});

/**
* We want to test that clicking the product badge replaces filters
* rather than compound them, but we don't yet have the Mirage
* factories to support this.
*/
todo(
"product badges have the correct hrefs when other filters are active",
async function (this: AuthenticatedAllRouteTestContext, assert) {
assert.true(false);
}
);
});