Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ProductBadge query value #305

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Fix ProductBadge query value #305

merged 2 commits into from
Aug 28, 2023

Conversation

jeffdaley
Copy link
Contributor

Fixes a bug where clicking a ProductBadge would compound rather than replace any active filters.

How to test:

  • From the all route, enable a non-product filter

THEN

  • Click a product badge on one of the results

OR

  • Click a document from the results, then click its productArea badge in the sidebar

Expected results
The productArea filter replaces the active filter

Actual results
The productArea filter compounds the active filter

@jeffdaley jeffdaley requested a review from a team as a code owner August 24, 2023 14:51
@jeffdaley jeffdaley merged commit 497f46f into main Aug 28, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/fix-product-badge-link branch August 28, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda