Tweak "request review" design #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| {{! <FlightIcon @size="16" @name="globe" /> }} | ||
| </div> | ||
| Your doc will appear on Hermes and Google Group emails. |
There was a problem hiding this comment.
Suggested change
| Your doc will appear on Hermes and Google Group emails. | |
| Your document will appear in Hermes and Google Workspace search. |
|
|
||
| <FlightIcon @size="16" @name="globe-private" /> | ||
| </div> | ||
| Published docs cannot be deleted. |
There was a problem hiding this comment.
Suggested change
| Published docs cannot be deleted. | |
| Published documents cannot be deleted but can archived. |
| <FlightIcon @size="16" @name="at-sign" /> | ||
| </div> | ||
| Approvers and people subscribed to | ||
| {{@document.product}} |
There was a problem hiding this comment.
Suggested change
| {{@document.product}} | |
| "{{@document.product}}" |
jfreda
approved these changes
Aug 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the "request review" elements to make the process clearer.
Some users mistake "request[ing a] review," which publishes the doc and triggers email notifications, for a lightweight "get eyes on this" type of action. The proposed design moves the idea of "publishing" to the forefront, and calls out, in explicit terms what the action does.
Current
Proposed