Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a share screen after publishing a doc #277

Merged
merged 6 commits into from
Aug 15, 2023
Merged

Show a share screen after publishing a doc #277

merged 6 commits into from
Aug 15, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Aug 2, 2023 •
edited
Loading

Adds a post-publish modal with a copyable share link:

CleanShot 2023-08-02 at 15 01 43@2x

@jeffdaley jeffdaley changed the title Jeffdaley/post publish modal Show a share screen after publishing a doc Aug 8, 2023
@jeffdaley jeffdaley marked this pull request as ready for review August 8, 2023 15:42
@jeffdaley jeffdaley requested a review from a team as a code owner August 8, 2023 15:42
@jeffdaley jeffdaley added the enhancement New feature or request label Aug 9, 2023
jfreda
jfreda approved these changes Aug 15, 2023
View reviewed changes
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffdaley jeffdaley merged commit de670c4 into main Aug 15, 2023
2 checks passed
@jeffdaley jeffdaley deleted the jeffdaley/post-publish-modal branch August 15, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda