Add first-class link support to Related Resources #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
changed the title
jfreda
reviewed
Aug 9, 2023
Comment on lines
467
to
468
| if (docID.includes("?draft=false")) { | ||
| docID = docID.replace("?draft=false", ""); |
There was a problem hiding this comment.
Might be more resilient to check with endsWith() and then trim with slice() or something? It's an edge case, but the current code would execute on ?draft=false in the middle of the string.
| void this.args.search(this.dd, this.query); | ||
| break; | ||
| case RelatedResourceQueryType.AlgoliaGetObject: | ||
| let docID = this.query.split("/document/").pop(); |
There was a problem hiding this comment.
Would this assume that any URL with /document/ in it is a Google Docs URL? We might want to check for the full https://docs.google.com/document/d/ prefix instead?
jeffdaley
force-pushed
the
jeffdaley/recognize-first-class-links
branch
from
f4e71e1
to
fb4439b
Compare
jeffdaley
force-pushed
the
jeffdaley/recognize-first-class-links
branch
from
fb4439b
to
69214d0
Compare
jfreda
approved these changes
Aug 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for first-class Hermes links in the Related Resources input.
getObjectquery based on the:document_id[validShortLink]/[validDocType]/[invalidDocNumber])