Make ProductArea badges interactive #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jul 25, 2023
Comment on lines
+38
to
+42
| <Person | ||
| @ignoreUnknown={{true}} | ||
| @imgURL={{@avatar}} | ||
| @email="{{@owner}}" | ||
| /> |
There was a problem hiding this comment.
We can make this clickable in another PR.
jfreda
approved these changes
Aug 10, 2023
| {{! | ||
| We create a click area that extends beyond the edges of its relative container. | ||
| This makes the parent div clickable without having to wrap itself in a link, | ||
| and lets us nest interactive elements (e.g., ProductBadgeLink) in a way that improves the mouse experience without sacrificing accessibility. |
Comment on lines
37
to
54
| protected get route() { | ||
| const { currentRouteName } = this.router; | ||
|
|
||
| if (!currentRouteName) { | ||
| return "authenticated.all"; | ||
| } | ||
|
|
||
| if (currentRouteName.includes("drafts")) { | ||
| return "authenticated.drafts"; | ||
| } | ||
|
|
||
| if (currentRouteName.includes("my")) { | ||
| return "authenticated.my"; | ||
| } | ||
|
|
||
| return "authenticated.all"; | ||
| } | ||
| } |
There was a problem hiding this comment.
I couldn't immediately tell why we needed this logic - maybe a comment would help?
There was a problem hiding this comment.
Yeah I probably overcomplicated it anyway 😅
Updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes ProductArea badges clickable to initiate a product filter. Badges on the
/myand/draftsare scoped to keep you on that route. All other users point to/all.