Update editingIsDisabled conditions
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
commented
Jul 19, 2023
| @@ -125,7 +125,7 @@ | |||
|
|
|||
| <div class="flex flex-col items-start space-y-2"> | |||
| <Document::Sidebar::SectionHeader @title="Product/Area" /> | |||
| {{#if this.isDraft}} | |||
| {{#if (and this.isDraft this.userHasEditPrivileges)}} | |||
There was a problem hiding this comment.
Tightening this now that we have the concept of Shareable Drafts (#261)
jeffdaley
commented
Jul 19, 2023
| // true is the doc is a draft/in review/approved and the user is not an owner, contributor, or approver | ||
| return !this.userHasEditPrivileges; | ||
| } else if (this.docIsInReview || this.docIsApproved) { | ||
| return !this.isOwner; |
There was a problem hiding this comment.
Important to note: This method is called editingIsDisabled.
anubhavmishra
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the front-end editing conditions to match the back end. Here's where things currently stand:
We'll likely tweak these permissions further (e.g., to include "view" access for approvers and stakeholders), but that will be handled separately.
TODO: Write permissions-based tests.