Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API for shareable drafts #261

Merged
merged 6 commits into from
Jul 18, 2023
Merged

Add API for shareable drafts #261

merged 6 commits into from
Jul 18, 2023

Conversation

jfreda
Copy link
Contributor

@jfreda jfreda commented Jul 18, 2023

This PR adds an API for sharing drafts documents with the Google Workspace organization.

Breaking changes

  • New required google_workspace.domain config attribute:
google_workspace {
  // domain is the Google Workspace domain (e.g., "hashicorp.com").
  domain = "your-domain-dot-com"
}

Note: For document drafts that are stored in shared drive folders in Google Workspace, this feature may need "Allow people who aren't shared drive members to access files" checked in the Shared drive settings for the shared drive. The screenshot attached shows the Shared drive settings.

New API endpoints

  • /api/v1/drafts/{document_id}/shareable
    • Methods: GET, PUT

@jfreda jfreda added enhancement New feature or request breaking changes PR contains breaking changes labels Jul 18, 2023
@jfreda jfreda requested a review from a team as a code owner July 18, 2023 01:58
Copy link
Contributor

@anubhavmishra anubhavmishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments and suggestion! Overall looks good!

internal/api/documents.go Outdated Show resolved Hide resolved
internal/cmd/commands/server/server.go Outdated Show resolved Hide resolved
@jfreda jfreda merged commit e69136b into main Jul 18, 2023
1 check passed
@jfreda jfreda deleted the jfreda/add-shareable-drafts branch July 18, 2023 19:29
This was referenced Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes PR contains breaking changes enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants