Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new configurations to FloatingUI component #237

Merged
merged 6 commits into from
Jun 27, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Jun 26, 2023

  • Adds a null placement option to ignore dynamic positioning.
  • Adds a disableClose argument

These are admittedly roundabout ways of extending the DropdownList components to work in non-popover contexts. I intend to improve this in future iterations, after the dust of #219 has settled.

@jeffdaley jeffdaley requested a review from a team as a code owner June 26, 2023 20:40
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

float on

@jeffdaley jeffdaley merged commit 90dbea9 into main Jun 27, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/unfloat-floating-ui branch June 27, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants