Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand DropdownList functions #239

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Expand DropdownList functions #239

merged 11 commits into from
Jun 27, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented Jun 27, 2023 •
edited
Loading

  • Adds an isLoading argument for async lists. The component now yields a <:loading> block that overrides the default spinner.
  • Adds support for a custom <:no-matches> block to override the default design.
  • Adds support for the recent disableClose and null Placement changes to FloatingUI

@jeffdaley jeffdaley marked this pull request as ready for review June 27, 2023 19:40
@jeffdaley jeffdaley requested a review from a team as a code owner June 27, 2023 19:40
@jeffdaley jeffdaley merged commit f808c1e into main Jun 27, 2023
1 check passed
@jeffdaley jeffdaley deleted the jeffdaley/expand-dropdown-list branch June 27, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfreda jfreda jfreda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffdaley @jfreda