Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ProductSelect component #187

Merged
merged 16 commits into from
Jun 2, 2023
Merged

Add ProductSelect component #187

merged 16 commits into from
Jun 2, 2023

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented May 31, 2023

Pending #185

Adds a ProductSelect component that will be used in the New Doc form and the Document draft sidebar.

CleanShot 2023-05-30 at 20 18 14@2x

@jeffdaley jeffdaley marked this pull request as ready for review May 31, 2023 01:47
@jeffdaley jeffdaley requested a review from a team as a code owner May 31, 2023 01:47
Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jeffdaley jeffdaley merged commit b4b0552 into main Jun 2, 2023
@jeffdaley jeffdaley deleted the jeffdaley/product-select branch June 2, 2023 17:48
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* BadgeDropdownList component

* BadgeDropdownList component

* Add custom-item test

* Remove unnecessary comment

* Resolve merge conflict

* ProductSelect component

* Add list item tests

* Tests, styles, cleanup

* Add onChange test

* Pass @ICON into component

* Remove unused property

* Revert unintended change

* Padding tweak; Prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants