Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BadgeDropdownList component #185

Merged
merged 7 commits into from
May 31, 2023
Merged

Conversation

jeffdaley
Copy link
Contributor

@jeffdaley jeffdaley commented May 30, 2023

Adds a generic BadgeDropdownList component. This will be the basis of the ProductSelect input in the document sidebar.

By default, uses the CheckableItem component:
CleanShot 2023-05-30 at 16 42 44@2x

But can yield any custom item:
CleanShot 2023-05-30 at 16 44 23@2x

Copy link
Contributor

@jfreda jfreda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but not blocking 👍

web/app/components/inputs/badge-dropdown-list.hbs Outdated Show resolved Hide resolved
@jeffdaley jeffdaley merged commit ea2dbc1 into main May 31, 2023
@jeffdaley jeffdaley deleted the jeffdaley/badge-dropdown-list branch May 31, 2023 01:37
anuragprafulla pushed a commit to razorpay/hermes that referenced this pull request Jun 27, 2023
* BadgeDropdownList component

* BadgeDropdownList component

* Add custom-item test

* Remove unnecessary comment

* Resolve merge conflict

* Remove product specificity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants