fix(status): provider label honors config.yaml model.base_url (#3296 salvage) - #810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes statusno longer mislabels a custom endpoint as "OpenRouter" —_effective_provider_label()only checked the legacyOPENAI_BASE_URLenv var, ignoring the canonicalmodel.base_urlin config.yaml (which the runtime treats as the single source of truth).Salvage of the surviving hunk of NousResearch#3296 by @Mibayy — the PR's gateway
_handle_provider_commandhunk targets code removed on main (/providerwas absorbed into/model+/status, which already readmodel.base_url).Changes
hermes_cli/status.py: checkload_config()['model']['base_url']in addition to the env var before labeling "custom"tests/hermes_cli/test_status_provider_label.py: 5 tests (config base_url, env base_url, neither, blank, non-openrouter passthrough)scripts/release.py: AUTHOR_MAP entryValidation
Infographic
Nous Research
Mirror-of: NousResearch#57002
NousResearch#57002