Skip to content

fix(status): provider label honors config.yaml model.base_url (#3296 salvage) - #57002

Merged
teknium1 merged 1 commit into
mainfrom
salvage/3296-provider-label
Jul 2, 2026
Merged

fix(status): provider label honors config.yaml model.base_url (#3296 salvage)#57002
teknium1 merged 1 commit into
mainfrom
salvage/3296-provider-label

Conversation

@teknium1

@teknium1 teknium1 commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Summary

hermes status no longer mislabels a custom endpoint as "OpenRouter" — _effective_provider_label() only checked the legacy OPENAI_BASE_URL env var, ignoring the canonical model.base_url in config.yaml (which the runtime treats as the single source of truth).

Salvage of the surviving hunk of #3296 by @Mibayy — the PR's gateway _handle_provider_command hunk targets code removed on main (/provider was absorbed into /model + /status, which already read model.base_url).

Changes

  • hermes_cli/status.py: check load_config()['model']['base_url'] in addition to the env var before labeling "custom"
  • tests/hermes_cli/test_status_provider_label.py: 5 tests (config base_url, env base_url, neither, blank, non-openrouter passthrough)
  • scripts/release.py: AUTHOR_MAP entry

Validation

Result
new tests 5/5 pass

Infographic

infographic

Nous Research

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard area/config Config system, migrations, profiles P3 Low — cosmetic, nice to have labels Jul 2, 2026
@teknium1
teknium1 force-pushed the salvage/3296-provider-label branch from 97bd9a8 to 9bee322 Compare July 2, 2026 11:38
… is set

Salvage of the surviving hunk of #3296 by @Mibayy. The PR's gateway
_handle_provider_command hunk targets code removed on main (/provider was
absorbed into /model + /status, which already read model.base_url); the
hermes status mislabel was the remaining live symptom:
_effective_provider_label() only checked the legacy OPENAI_BASE_URL env var,
so a custom endpoint configured canonically in config.yaml still displayed
as OpenRouter.
@teknium1
teknium1 force-pushed the salvage/3296-provider-label branch from 9bee322 to 8f572fb Compare July 2, 2026 11:49
@teknium1
teknium1 merged commit 070ac2a into main Jul 2, 2026
31 checks passed
@teknium1
teknium1 deleted the salvage/3296-provider-label branch July 2, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Config system, migrations, profiles comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants