Release #289
Merged
Release #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix: Toggle modified notes (#188) * Fix: Toggle discussion nodes correctly * Feat: Show Help keymap in discussion tree winbar * Fix: Enable toggling nodes from the note body Previously, the cursor had to be placed on the first line of the note (the one with the author name) for toggling to work. * Fix: Enable toggling resolved status from child nodes Previously, the cursor had to be placed on the root node of the discussion for toggling resolved status to work. * Fix: Only try to show emoji popup on note nodes Without this fix, there was an error whenever the cursor moved to a file_name or path node in the "by_file_name" discussion tree. * Feat: Add keymap for toggling tree type Previously, tree type could only be set in the plugin configuration. Now it can be toggled within a session. The keymap "i" is chosen based on a similar functionality in DiffView. * Fix: Disable tree type toggling in Notes Tree type toggling only makes sense in the (linked) Discussions and making it possible in the Notes could confuse users.
Fix: Multi-line discussions. The calculation of a range for a multiline comment has been consolidated and moved into the location.lua file. This does not attempt to fix diagnostics. Refactor: It refactors the discussions code to split hunk parsing and management into a separate module Fix: Don't allow comments on modified buffers #194 by preventing comments on the reviewer when using --imply-local and when the working tree is dirty entirely. Refactor: It introduces a new List class for data aggregation, filtering, etc. Fix: It removes redundant API calls and refreshes from the discussion pane
Fix: Allow users to switch tabs while creating comments
Fixes an issue in the old sha where the index when iterating through the lines of the hunk in the old SHA was off by one
* Updated lua/gitlab/actions/discussions/signs.lua * Initial commit of changes * Updated lua/gitlab/actions/discussions/signs.lua * Updated lua/gitlab/actions/discussions/signs.lua * Updated lua/gitlab/actions/discussions/init.lua * Updated lua/gitlab/actions/discussions/signs.lua * Split up signs and diagnostics * Moved common to common file * Continued modularization * added formatting * Moved signs/diagnostic lines into appropriate files * Updated lua/gitlab/reviewer/init.lua * Renamed is_current_sha => is_current_sha_focused * Updated lua/gitlab/reviewer/init.lua * Moved actions.indicators => indicators * Split discussions/signs apart into separate modules * Fixed filter function, fixed discussions * Updated lua/gitlab/indicators/diagnostics.lua * Setting diagnostics, handling and catching errors * Greatly simplified diagnostics setup * Re-split multi-line * Updated lua/gitlab/indicators/diagnostics.lua * Setting up signs * Updated lua/gitlab/indicators/signs.lua * Updated signs + display options * Updated lua/gitlab/state.lua * Updated doc/gitlab.nvim.txt * Updated readme * Added deprecation warning * formatting
Fixes off-by one in new SHA comment creation, thank you @jakubbortlik for catching this
Fixes issue where jumping to the reviewer would jump to the wrong buffer (old SHA vs new SHA). Also addresses an issue in the refactor where ranged signs were being placed on top of comment signs.
Fixes typo in settings check, this is a #PATCH release
…211) fix: Calculate new line in ranged comment after all hunks correctly
Fix: Ranged comments in new SHA
fix: This MR fixes a missing function from the reviewer that was affecting the ability to add suggestion comments
Fixes an issue where the diagnostics were not being created correctly on a deleted line
This MR allows you to ignore bad x509 certificates when connecting to Gitlab (e.g. make an insecure connection). Helpful for self-hosted or enterprise environments where the instance is not up to date.
This MR removes the `<esc>` keybinding from the application for popups to avoid accidentally nuking existing changes. Addresses #239.
This MR deprecates the "backup" register which was a hot-fix used to deal with bugs upon comment and note creation
* Fixing labels and updating go gitlab * Fixing up labels.lua
Enables fetching of pipeline information on main and master branches. Allows plugin startup on main/master branches for future extensibility improvements.
This PR adds the ability to access the underlying data in the plugin, such as pipeline information, the information about a merge request, and other data. This data can be integrated into other plugins such as statusline plugins, or other workflows.
fix: correcting some problem with review mode
feat: Add API and keymap for copying web URL to clipboard
Fixes issues where we were jumping to the wrong buffer
fix: gets most recent pipeline for current branch by hitting different Gitlab API
* feat: Add keymaps for cycling popups in Summary and MR Confirmation popups= * feat: Add toggle_bool linewise action * fix: Don't include the HEAD pointer in the list of branches * fix: Enable excluding current branch from list of branches * feat: Add linewise action to select new target branch
fix: Fixes diagnostics for comments that are left "on a file" which do not have position information
feat: Adds authentication provider function Fixes #269
feat: Implements adding "draft" notes of all types to the review, and publishing them, either individually or all at once. Addresses feature request #223.
feat: Let users select a merge request directly within Neovim
fix: refresh issues with empty state when missing all draft notes or all regular notes
fix: restores focus to recent buffer after making comment
fix: issue with editing draft notes; jumping to correct position for draft notes; and replying (not supported) to draft notes.
feat: check the up-to-date status of the remote feature branch before creating a MR, starting a review, or opening the MR summary
feat: better error checking in git commands feat: allow toggling between live mode and draft mode, adds "D" keybinding to discussion tree
fix: We require some state from Packer, this fixes the docs to reflect a way to load that state prior to running the gitlab plugin. Fixes #94.
fix: do not allow line-linked comments on non-existent buffers
* Feat: Make toggle_draft_mode available outside discussion tree
* feat: implements refresh function for discussion tree view * fix: corrects collapsing tree nodes on create/edit
* Add support for draft note replies, e.g. replies to existing notes and comments in draft form
* fix: The base_sha should be used for calculating the correct diff hunks because it is also used for the DiffviewOpen command
fix: Use backticks in code suggestions (#292)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.