Skip to content

Fix: Use backticks in code suggestions #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2024
Merged

Fix: Use backticks in code suggestions #292

merged 1 commit into from
Apr 25, 2024

Conversation

@jakubbortlik
Copy link
Collaborator

@jakubbortlik jakubbortlik commented Apr 25, 2024

This PR fixes how backticks in code suggestions are identified:

  1. The original iteration compared to the indeces, not to the values of the table of all lines.
  2. The original regex didn't allow backtics with a filetype specification, e.g., "```bash".

@harrisoncramer harrisoncramer merged commit 85737e9 into harrisoncramer:develop Apr 25, 2024
@jakubbortlik jakubbortlik deleted the fix-backticks-in-suggestions branch May 1, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jakubbortlik @harrisoncramer