Skip to content

feat: roll Chrome to 152.0.7977.42 - #3553

Merged
kblok merged 7 commits into
masterfrom
cursor/implement-upstream-change-15330-a3ef
Aug 14, 2026
Merged

feat: roll Chrome to 152.0.7977.42#3553
kblok merged 7 commits into
masterfrom
cursor/implement-upstream-change-15330-a3ef

Conversation

@kblok

@kblok kblok commented Aug 13, 2026

Copy link
Copy Markdown
Member

Ports puppeteer/puppeteer#15330 from puppeteer-core-v25.7.0.

What changed

  • Updated Chrome.DefaultBuildId from 151.0.7922.77152.0.7977.42
  • Updated screen tests to assert opaque non-empty ids (Is.Not.Null.And.Not.Empty) instead of hardcoded "1" / "2", matching upstream expect.any(String) — Chrome 152 changed screen id format (e.g. 2300000001)
  • Left the canary FAIL for touchscreen three-touches (crbug.com/433304196); it still reproduces on this build

Why

Keeps the pinned Chrome revision in sync with puppeteer-core and unblocks CI against the new screen id shape.

Test plan

  • Screen / add-remove-screen tests under BROWSER=CHROME PROTOCOL=cdp
  • Full CI green
Open in Web Open in Cursor 

cursoragent and others added 5 commits August 13, 2026 20:29
Update DefaultBuildId to match puppeteer/puppeteer#15330 and remove the
canary FAIL expectation for touchscreen three-touches (fixed in Chrome 152).

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Chrome 152 changed screen ids from sequential "1"/"2" to opaque values.
Match upstream's expect.any(String) checks, and keep the three-touches
canary FAIL (crbug.com/433304196 still reproduces).

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
@cursor cursor Bot changed the title Implement upstream PR #15330 feat: roll Chrome to 152.0.7977.42 Aug 14, 2026
@kblok

kblok commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

Upstream PR #15330 → PuppeteerSharp

Upstream

  • PR: puppeteer/puppeteer#15330
  • Title: feat: roll to Chrome 152.0.7977.42
  • Summary: Bump the pinned Chrome revision to 152.0.7977.42.

PuppeteerSharp mapping

Upstream PuppeteerSharp
revisions.ts Chrome build id BrowserData/Chrome.DefaultBuildId
Screen id assertions expect.any(String) Screen tests assert non-empty id (Chrome 152 opaque ids)

Changes

  1. Chrome.DefaultBuildId151.0.7922.77152.0.7977.42.
  2. ScreensTests / AddRemoveScreenTests – Assert Id is non-null/non-empty instead of hardcoded "1" / "2" (Chrome 152 returns opaque ids such as 2300000001; matches upstream).
  3. Canary – Kept FAIL for touchscreen three-touches (crbug.com/433304196); still reproduces on this build.

Verification

  • Screen / add-remove-screen tests under BROWSER=CHROME PROTOCOL=cdp: passed

@kblok
kblok marked this pull request as ready for review August 14, 2026 14:22
@kblok

kblok commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

CI follow-up

CHROME-headful-windows-latest-cdp was failing on:

ShouldKeepConnectedAfterTheLastPageIsClosedTarget.createTarget: Failed to open a new tab

That reproduces under Chrome 152 + headful + Windows (headless / Linux headful are fine). Added a canary FAIL expectation for that combo so the suite can go green while the browser bug is tracked.

Target.createTarget fails after closing the last page in that
configuration; mark it as a canary expectation.

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
@kblok

kblok commented Aug 14, 2026

Copy link
Copy Markdown
Member Author

Removed the KeepConnected canary FAIL entry — it is not in upstream CanaryTestExpectations.json, so it should not live in TestExpectations.canary.json.

Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
@kblok
kblok merged commit c9f57dc into master Aug 14, 2026
17 checks passed
@kblok
kblok deleted the cursor/implement-upstream-change-15330-a3ef branch August 14, 2026 21:30
@kblok kblok mentioned this pull request Aug 14, 2026
sondresjolyst pushed a commit to sondresjolyst/garge-api that referenced this pull request Aug 24, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp)
from 25.5.0 to 25.7.0.

<details>
<summary>Release notes</summary>

_Sourced from [PuppeteerSharp's
releases](https://github.com/hardkoded/puppeteer-sharp/releases)._

## 25.7.0

## What's Changed
* fix: roll Firefox to 153.0.4 by @​kblok in
hardkoded/puppeteer-sharp#3554
* docs: clarify CdpHttpRequest owns its logger (upstream #​15338 N/A) by
@​kblok in hardkoded/puppeteer-sharp#3552
* feat(tracing): support BufferSize option in Tracing.StartAsync by
@​kblok in hardkoded/puppeteer-sharp#3551
* refactor: track CDP listeners with DisposableActionsStack by @​kblok
in hardkoded/puppeteer-sharp#3555
* feat: roll Chrome to 152.0.7977.42 by @​kblok in
hardkoded/puppeteer-sharp#3553
* Bump version to 25.7.0 by @​kblok in
hardkoded/puppeteer-sharp#3556


**Full Changelog**:
hardkoded/puppeteer-sharp@v25.6.0...v25.7.0

## 25.6.0

## What's Changed
* Replace hand-rolled retry/timeout plumbing with RxSharp by @​kblok in
hardkoded/puppeteer-sharp#3520
* Roll browsers: Chrome 151.0.7922.77, Firefox 153.0.3 by @​kblok in
hardkoded/puppeteer-sharp#3546
* Propagate ILoggerFactory through BiDi sessions, frames and realms by
@​kblok in hardkoded/puppeteer-sharp#3547
* Default BidiRealm logger to NullLogger by @​kblok in
hardkoded/puppeteer-sharp#3550
* Don't fail per-frame CDP fan-out when an OOP iframe goes away by
@​kblok in hardkoded/puppeteer-sharp#3548


**Full Changelog**:
hardkoded/puppeteer-sharp@v25.5.0...v25.6.0

Commits viewable in [compare
view](hardkoded/puppeteer-sharp@v25.5.0...v25.7.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PuppeteerSharp&package-manager=nuget&previous-version=25.5.0&new-version=25.7.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants