feat(tracing): support BufferSize option in Tracing.StartAsync - #3551
Merged
Conversation
Port upstream Puppeteer PR #15328: add TracingOptions.BufferSize and pass it as traceBufferSizeInKb via CDP Tracing.start TraceConfig. Migrate Tracing.start to use TraceConfig with included/excluded categories to match upstream. Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
Co-authored-by: Darío Kondratiuk <dariokondratiuk@gmail.com>
cursor
Bot
changed the title
Member
Author
Upstream PR #15328 → PuppeteerSharpUpstream
PuppeteerSharp mapping
Changes
Verification
|
kblok
marked this pull request as ready for review
August 14, 2026 14:22
Merged
This was referenced Aug 16, 2026
sondresjolyst
pushed a commit
to sondresjolyst/garge-api
that referenced
this pull request
Aug 24, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.5.0 to 25.7.0. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.7.0 ## What's Changed * fix: roll Firefox to 153.0.4 by @kblok in hardkoded/puppeteer-sharp#3554 * docs: clarify CdpHttpRequest owns its logger (upstream #15338 N/A) by @kblok in hardkoded/puppeteer-sharp#3552 * feat(tracing): support BufferSize option in Tracing.StartAsync by @kblok in hardkoded/puppeteer-sharp#3551 * refactor: track CDP listeners with DisposableActionsStack by @kblok in hardkoded/puppeteer-sharp#3555 * feat: roll Chrome to 152.0.7977.42 by @kblok in hardkoded/puppeteer-sharp#3553 * Bump version to 25.7.0 by @kblok in hardkoded/puppeteer-sharp#3556 **Full Changelog**: hardkoded/puppeteer-sharp@v25.6.0...v25.7.0 ## 25.6.0 ## What's Changed * Replace hand-rolled retry/timeout plumbing with RxSharp by @kblok in hardkoded/puppeteer-sharp#3520 * Roll browsers: Chrome 151.0.7922.77, Firefox 153.0.3 by @kblok in hardkoded/puppeteer-sharp#3546 * Propagate ILoggerFactory through BiDi sessions, frames and realms by @kblok in hardkoded/puppeteer-sharp#3547 * Default BidiRealm logger to NullLogger by @kblok in hardkoded/puppeteer-sharp#3550 * Don't fail per-frame CDP fan-out when an OOP iframe goes away by @kblok in hardkoded/puppeteer-sharp#3548 **Full Changelog**: hardkoded/puppeteer-sharp@v25.5.0...v25.6.0 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.5.0...v25.7.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports puppeteer/puppeteer#15328 from puppeteer-core-v25.7.0.
What changed
TracingOptions.BufferSize(int?), forwarded to CDP astraceConfig.traceBufferSizeInKbTracing.StartAsyncto send aTraceConfigwith included/excluded categories (required to set buffer size; matches upstream)TracingTraceConfigmessaging type + JSON source-gen registrationshould support bufferSize optiontestWhy
Upstream tracing now allows callers to size the in-memory trace buffer. Without this, PuppeteerSharp cannot pass
bufferSizethrough to Chrome.Test plan
BROWSER=CHROME PROTOCOL=cdpTracing tests