Skip to content

fix: disable WebUIOmniboxPopup and WebUIOmniboxAimPopup (#15278) - #3538

Merged
kblok merged 1 commit into
masterfrom
kblok-port-upstream-15278
Aug 5, 2026
Merged

fix: disable WebUIOmniboxPopup and WebUIOmniboxAimPopup (#15278)#3538
kblok merged 1 commit into
masterfrom
kblok-port-upstream-15278

Conversation

@kblok

@kblok kblok commented Aug 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Port upstream Puppeteer PR #15278.
  • Disable WebUIOmniboxPopup and WebUIOmniboxAimPopup in PuppeteerSharp default Chrome launch args (ChromeLauncher.GetDefaultArgs).
  • Add a directly related launcher test asserting both features are disabled by default.

Changes

  • lib/PuppeteerSharp/ChromeLauncher.cs
    • Added WebUIOmniboxPopup and WebUIOmniboxAimPopup to the default --disable-features list.
  • lib/PuppeteerSharp.Tests/ChromeLauncherTests/DefaultArgsTests.cs
    • Added DisablesWebUIOmniboxPopupAndWebUIOmniboxAimPopupByDefault.

Validation

  • BROWSER=CHROME PROTOCOL=cdp dotnet test lib/PuppeteerSharp.Tests/PuppeteerSharp.Tests.csproj --filter "FullyQualifiedName~PuppeteerSharp.Tests.ChromeLauncherTests.DefaultArgsTests" --no-build -- NUnit.TestOutputXml=TestResults

Upstream reference: puppeteer/puppeteer#15278

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@kblok
kblok merged commit a75a75b into master Aug 5, 2026
27 of 28 checks passed
@kblok
kblok deleted the kblok-port-upstream-15278 branch August 5, 2026 12:02
sondresjolyst pushed a commit to sondresjolyst/garge-api that referenced this pull request Aug 17, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp)
from 25.4.0 to 25.5.0.

<details>
<summary>Release notes</summary>

_Sourced from [PuppeteerSharp's
releases](https://github.com/hardkoded/puppeteer-sharp/releases)._

## 25.5.0

## What's Changed
* fix: PWA launch returning a page with an empty URL on Windows by
@​kblok in hardkoded/puppeteer-sharp#3529
* fix: bound CdpPage.CloseAsync's wait for target close confirmation by
@​kblok in hardkoded/puppeteer-sharp#3530
* fix: close remaining race in PWA launch where page.Url could still be
empty by @​kblok in
hardkoded/puppeteer-sharp#3531
* fix: reject PWA access when network restrictions are configured
(#​15271) by @​kblok in
hardkoded/puppeteer-sharp#3540
* feat: track dialog status (#​15266) by @​kblok in
hardkoded/puppeteer-sharp#3542
* feat: roll to Firefox 153.0 (#​15258) by @​kblok in
hardkoded/puppeteer-sharp#3537
* fix: roll to Chrome 151.0.7922.71 (#​15272) by @​kblok in
hardkoded/puppeteer-sharp#3535
* fix: disable WebUIOmniboxPopup and WebUIOmniboxAimPopup (#​15278) by
@​kblok in hardkoded/puppeteer-sharp#3538
* fix: roll to Firefox 153.0.1 (#​15269) by @​kblok in
hardkoded/puppeteer-sharp#3536
* fix: do not override user agent when nothing is emulated (#​15274) by
@​kblok in hardkoded/puppeteer-sharp#3539
* fix: forward headers to browserURL discovery and WebSocket connection
(#​15238) by @​kblok in
hardkoded/puppeteer-sharp#3541
* Bump version to 25.5.0 by @​kblok in
hardkoded/puppeteer-sharp#3543


**Full Changelog**:
hardkoded/puppeteer-sharp@v25.4.0...v25.5.0

Commits viewable in [compare
view](hardkoded/puppeteer-sharp@v25.4.0...v25.5.0).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=PuppeteerSharp&package-manager=nuget&previous-version=25.4.0&new-version=25.5.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant