fix: close remaining race in PWA launch where page.Url could still be empty - #3531
Merged
Conversation
…chPWAAsync The previous fix (#3529) waited on target.InitializedTask, which only reflects CDP's Target domain reporting a URL. page.Url comes from a separate pathway (Page.getFrameTree via the Page domain), so the two could still race under load - most visibly on the slower Windows CI runners, where page.Url could still be empty right after LaunchPWAAsync returned.
This was referenced Aug 6, 2026
This was referenced Aug 14, 2026
sondresjolyst
pushed a commit
to sondresjolyst/garge-api
that referenced
this pull request
Aug 17, 2026
Updated [PuppeteerSharp](https://github.com/hardkoded/puppeteer-sharp) from 25.4.0 to 25.5.0. <details> <summary>Release notes</summary> _Sourced from [PuppeteerSharp's releases](https://github.com/hardkoded/puppeteer-sharp/releases)._ ## 25.5.0 ## What's Changed * fix: PWA launch returning a page with an empty URL on Windows by @kblok in hardkoded/puppeteer-sharp#3529 * fix: bound CdpPage.CloseAsync's wait for target close confirmation by @kblok in hardkoded/puppeteer-sharp#3530 * fix: close remaining race in PWA launch where page.Url could still be empty by @kblok in hardkoded/puppeteer-sharp#3531 * fix: reject PWA access when network restrictions are configured (#15271) by @kblok in hardkoded/puppeteer-sharp#3540 * feat: track dialog status (#15266) by @kblok in hardkoded/puppeteer-sharp#3542 * feat: roll to Firefox 153.0 (#15258) by @kblok in hardkoded/puppeteer-sharp#3537 * fix: roll to Chrome 151.0.7922.71 (#15272) by @kblok in hardkoded/puppeteer-sharp#3535 * fix: disable WebUIOmniboxPopup and WebUIOmniboxAimPopup (#15278) by @kblok in hardkoded/puppeteer-sharp#3538 * fix: roll to Firefox 153.0.1 (#15269) by @kblok in hardkoded/puppeteer-sharp#3536 * fix: do not override user agent when nothing is emulated (#15274) by @kblok in hardkoded/puppeteer-sharp#3539 * fix: forward headers to browserURL discovery and WebSocket connection (#15238) by @kblok in hardkoded/puppeteer-sharp#3541 * Bump version to 25.5.0 by @kblok in hardkoded/puppeteer-sharp#3543 **Full Changelog**: hardkoded/puppeteer-sharp@v25.4.0...v25.5.0 Commits viewable in [compare view](hardkoded/puppeteer-sharp@v25.4.0...v25.5.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3529 fixed the common case of this Windows-only flake by waiting for the CDP Target domain to report a URL before creating the page. Turns out that wasn't the full story:
page.Urlis populated by a completely separate pathway (Page.getFrameTreeover the Page domain, insidetarget.PageAsync()), and that can still lag behind even after the target itself is "initialized." Under the slower Windows CI runners this showed up again aspage.Urlbeing empty right afterLaunchPWAAsyncreturned.Now, if
page.Urlis still empty after the page is created, we wait for the main frame to actually report its navigated URL before handing the page back.