Skip to content

Add local fonts to OverridePermissions enum#3157

Merged
kblok merged 7 commits intohardkoded:masterfrom
ciaranodonnell:add-local-fonts-to-overridepermissions
Feb 19, 2026
Merged

Add local fonts to OverridePermissions enum#3157
kblok merged 7 commits intohardkoded:masterfrom
ciaranodonnell:add-local-fonts-to-overridepermissions

Conversation

@ciaranodonnell
Copy link
Contributor

local-fonts is a permission that isn't currently in the enum.

See docs for details:
https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Permissions-Policy/local-fonts

Copy link
Member

@kblok kblok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one!

kblok added a commit that referenced this pull request Feb 18, 2026
Add LocalFonts to OverridePermission enum and add the corresponding
case in BidiBrowserContext.GetPermissionName() to prevent
ArgumentOutOfRangeException when iterating all permissions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@kblok
Copy link
Member

kblok commented Feb 18, 2026

@ciaranodonnell You have to update BidiBrowserContext.GetPermissionName. I tried to do it myself, but I can't push to your branch.

@kblok kblok merged commit 82386c6 into hardkoded:master Feb 19, 2026
12 of 13 checks passed
@kblok
Copy link
Member

kblok commented Feb 19, 2026

@ciaranodonnell v21.1.1 is up!

kblok added a commit that referenced this pull request Feb 19, 2026
* Add BrowserContext.SetPermissionAsync API (#3112)

Implements the upstream setPermission API that provides fine-grained
control over browser permissions. Unlike OverridePermissionsAsync
(now deprecated), this allows setting individual permissions to
specific states (granted, denied, prompt) without affecting others.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove [Obsolete] attribute from OverridePermissionsAsync

The CI format check treats CS0618 warnings as errors, and existing
tests still call OverridePermissionsAsync.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Add LocalFonts permission with BiDi support (#3157)

Add LocalFonts to OverridePermission enum and add the corresponding
case in BidiBrowserContext.GetPermissionName() to prevent
ArgumentOutOfRangeException when iterating all permissions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants