Add BrowserContext.SetPermissionAsync API (#3112)#3153
Merged
Conversation
Implements the upstream setPermission API that provides fine-grained control over browser permissions. Unlike OverridePermissionsAsync (now deprecated), this allows setting individual permissions to specific states (granted, denied, prompt) without affecting others. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The CI format check treats CS0618 warnings as errors, and existing tests still call OverridePermissionsAsync. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add LocalFonts to OverridePermission enum and add the corresponding case in BidiBrowserContext.GetPermissionName() to prevent ArgumentOutOfRangeException when iterating all permissions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetPermissionAsyncmethod toIBrowserContextandIBrowserfor fine-grained permission controlgranted,denied, orpromptstates viaPermissionDescriptorandPermissionEntryclasses*wildcard origin) and BiDi support (with appropriate unsupported feature checks)OverridePermissionsAsyncas deprecated in favor of the new APITest plan
*origin)OverridePermissionsAsynctests still passCloses #3112
🤖 Generated with Claude Code