Skip to content

Make sure we run Page.enable before Page.getFrameTree #3101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kblok merged 2 commits into from
Jan 31, 2026
Merged

Make sure we run Page.enable before Page.getFrameTree #3101

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a64c8a
Make sure we run Page.enable before Page.getFrameTree
kblok Jan 21, 2026
ec96d4b
Merge branch 'master' into fix-page-enable-concurrency
kblok Jan 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lib/PuppeteerSharp/Cdp/FrameManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ internal async Task InitializeAsync(CDPSession client)
_frameTreeHandled.TrySetResult(true);
_frameTreeHandled = new TaskCompletionSource<bool>(TaskCreationOptions.RunContinuationsAsynchronously);
var networkInitTask = NetworkManager.AddClientAsync(client);
var getFrameTreeTask = client.SendAsync<PageGetFrameTreeResponse>("Page.getFrameTree");
var autoAttachTask = client != Client
? client.SendAsync("Target.setAutoAttach", new TargetSetAutoAttachRequest
{
Expand All @@ -128,8 +127,11 @@ internal async Task InitializeAsync(CDPSession client)
})
: Task.CompletedTask;

// Page.enable must be sent before Page.getFrameTree to ensure frame events are received
await client.SendAsync("Page.enable").ConfigureAwait(false);

var getFrameTreeTask = client.SendAsync<PageGetFrameTreeResponse>("Page.getFrameTree");
await Task.WhenAll(
client.SendAsync("Page.enable"),
getFrameTreeTask,
autoAttachTask).ConfigureAwait(false);

Expand Down
Loading