Make sure we run Page.enable before Page.getFrameTree#3101
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes race conditions in the CDP Frame Manager by ensuring that Page.enable is sent and completes before Page.getFrameTree is called. This sequencing is critical to ensure frame events are properly received.
Changes:
- Moved
Page.enablecall to execute beforePage.getFrameTreeinstead of running them concurrently - Added an explanatory comment documenting the required ordering
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 2, 2026
This was referenced Feb 13, 2026
This was referenced Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some race conditions here.
Closes #3100