Skip to content

Mark LogProcess property as obsolete #3072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kblok merged 5 commits into from
Jan 5, 2026
Merged

Mark LogProcess property as obsolete #3072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b6f5654
Initial plan
Copilot Jan 5, 2026
ff7b0d3
Mark LogProcess as obsolete and remove its usage
Copilot Jan 5, 2026
9e6d6f7
Complete implementation - all checks passed
Copilot Jan 5, 2026
39eb4a0
Remove accidentally added nuget.exe and update .gitignore
Copilot Jan 5, 2026
8c2973a
Merge branch 'master' into copilot/remove-logprocess-property
kblok Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,7 @@ PublishScripts/
# NuGet v3's project.json files produces more ignorable files
*.nuget.props
*.nuget.targets
.nuget/

# Microsoft Azure Build Output
csx/
Expand Down
1 change: 0 additions & 1 deletion lib/PuppeteerSharp.Tests/TestConstants.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@ public static class TestConstants
Browser = IsChrome ? SupportedBrowser.Chrome : SupportedBrowser.Firefox,
EnqueueAsyncMessages = Convert.ToBoolean(Environment.GetEnvironmentVariable("ENQUEUE_ASYNC_MESSAGES") ?? "false"),
Timeout = 0,
LogProcess = true,
#if NETCOREAPP
EnqueueTransportMessages = false
#else
Expand Down
4 changes: 4 additions & 0 deletions lib/PuppeteerSharp/LaunchOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ public bool Devtools
/// <summary>
/// Logs process counts after launching chrome and after exiting.
/// </summary>
/// <remarks>
/// This property is obsolete and has no effect. It will be removed in a future version.
/// </remarks>
[Obsolete("This property has no effect and will be removed in a future version.")]
public bool LogProcess { get; set; }

/// <summary>
Expand Down
Loading