Merged
Conversation
Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove unused LogProcess property from LaunchOptions
Mark LogProcess property as obsolete
Jan 5, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the unused LogProcess property from LaunchOptions by marking it as obsolete. The property was only set in test code but never actually used, and has no equivalent in upstream Puppeteer.
- Marked
LogProcessproperty as[Obsolete]with a clear deprecation message - Removed the
LogProcess = trueassignment from test configuration
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/PuppeteerSharp/LaunchOptions.cs | Added [Obsolete] attribute and remarks to LogProcess property to indicate it has no effect |
| lib/PuppeteerSharp.Tests/TestConstants.cs | Removed the unused LogProcess = true setting from DefaultBrowserOptions() |
| .gitignore | Added .nuget/ directory to ignore list (appears unrelated to PR purpose) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Feb 2, 2026
This was referenced Feb 13, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LaunchOptions.LogProcessis set in one location but never used. No equivalent exists in upstream Puppeteer. Maintainer confirmed it's "old debugging stuff."Changes
[Obsolete]attribute with deprecation messageLogProcess = trueassignment.nuget/to prevent build artifact commitsImpact
Existing code continues to compile with a compiler warning. Property can be removed in a future major version.
Original prompt
LaunchOptions.LogProcessdoesn't do anything #3012💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.