Skip to content

Mark LogProcess property as obsolete#3072

Merged
kblok merged 5 commits intomasterfrom
copilot/remove-logprocess-property
Jan 5, 2026
Merged

Mark LogProcess property as obsolete#3072
kblok merged 5 commits intomasterfrom
copilot/remove-logprocess-property

Conversation

Copy link
Contributor

Copilot AI commented Jan 5, 2026

LaunchOptions.LogProcess is set in one location but never used. No equivalent exists in upstream Puppeteer. Maintainer confirmed it's "old debugging stuff."

Changes

  • LaunchOptions.cs: Added [Obsolete] attribute with deprecation message
  • TestConstants.cs: Removed LogProcess = true assignment
  • .gitignore: Added .nuget/ to prevent build artifact commits

Impact

Existing code continues to compile with a compiler warning. Property can be removed in a future major version.

var options = new LaunchOptions 
{
    LogProcess = true  // Warning CS0618: 'LaunchOptions.LogProcess' is obsolete: 
                       // 'This property has no effect and will be removed in a future version.'
};
Original prompt

This section details on the original issue you should resolve

<issue_title>LaunchOptions.LogProcess doesn't do anything</issue_title>
<issue_description>LogProcess is only set in a single place in the code base, never used, and setting it in user code doesn't seem to do anything.
It should either be deprecated / removed, or implemented according to its description, as it would be a useful feature (for both browsers). It doesn't seem to have an equivalent in upstream Puppeteer.

/// <summary>
/// Logs process counts after launching chrome and after exiting.
/// </summary>
public bool LogProcess { get; set; }

Also looking at the class' code, properties and the class itself should clarify which options are Chrome/Firefox-only or affect both.</issue_description>

Comments on the Issue (you are @copilot in this section)

@kblok That's true! Old debugging stuff

Custom agent used: Bidi migration
Implement bidi code


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
@kblok kblok marked this pull request as ready for review January 5, 2026 12:18
Copilot AI review requested due to automatic review settings January 5, 2026 12:18
Copilot AI and others added 2 commits January 5, 2026 12:19
Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
Co-authored-by: kblok <2198466+kblok@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove unused LogProcess property from LaunchOptions Mark LogProcess property as obsolete Jan 5, 2026
Copilot AI requested a review from kblok January 5, 2026 12:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the unused LogProcess property from LaunchOptions by marking it as obsolete. The property was only set in test code but never actually used, and has no equivalent in upstream Puppeteer.

  • Marked LogProcess property as [Obsolete] with a clear deprecation message
  • Removed the LogProcess = true assignment from test configuration

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
lib/PuppeteerSharp/LaunchOptions.cs Added [Obsolete] attribute and remarks to LogProcess property to indicate it has no effect
lib/PuppeteerSharp.Tests/TestConstants.cs Removed the unused LogProcess = true setting from DefaultBrowserOptions()
.gitignore Added .nuget/ directory to ignore list (appears unrelated to PR purpose)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kblok kblok merged commit 412fcf6 into master Jan 5, 2026
10 of 13 checks passed
@kblok kblok deleted the copilot/remove-logprocess-property branch February 12, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LaunchOptions.LogProcess doesn't do anything

3 participants