Skip to content

Commit

Permalink
ARM64: juno: disable NOR flash node by default
Browse files Browse the repository at this point in the history
After discussing on the mailing list it turns out that
accessing the flash memory from the kernel can disrupt CPU
sleep states and CPU hotplugging, so let's disable this
DT node by default. Setups that want to access the flash
can modify this entry to enable the flash again.

Quoting Sudeep Holla: "the firmware assumes the flash is
always in read mode while Linux leaves NOR flash in
"read id" mode after initialization."

Reported-by: Sudeep Holla <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: Sudeep Holla <[email protected]>
Cc: Liviu Dudau <[email protected]>
Cc: Lorenzo Pieralisi <[email protected]>
Cc: Catalin Marinas <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Ryan Harkin <[email protected]>
Fixes: 5078f77 "ARM64: juno: add NOR flash to device tree"
Signed-off-by: Linus Walleij <[email protected]>
Signed-off-by: Olof Johansson <[email protected]>
  • Loading branch information
linusw authored and olofj committed Oct 31, 2015
1 parent 7c62f29 commit 980bbff
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions arch/arm64/boot/dts/arm/juno-motherboard.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,13 @@
linux,part-probe = "afs";
reg = <0 0x00000000 0x04000000>;
bank-width = <4>;
/*
* Unfortunately, accessing the flash disturbs
* the CPU idle states (suspend) and CPU
* hotplug of the platform. For this reason,
* flash hardware access is disabled by default.
*/
status = "disabled";
};

ethernet@2,00000000 {
Expand Down

0 comments on commit 980bbff

Please sign in to comment.