Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend: unit tests for replace roman numbers #3091

Open
wants to merge 7 commits into
base: beta
Choose a base branch
from
Open

Backend: unit tests for replace roman numbers #3091

wants to merge 7 commits into from
+68 −11

Conversation

hannibal002
Copy link
Owner

@hannibal002 hannibal002 commented Dec 19, 2024 •
edited
Loading

What

This is a unit test that follows the already merged PR

Changelog Technical Details

  • Added unit test for replace roman numerals. - hannibal2

@hannibal002 hannibal002 added the Soon This Pull Request will be merged within the next couple of betas label Dec 19, 2024
@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 19, 2024
@github-actions github-actions bot added the Backend A backend pull request that will be merged soon label Dec 19, 2024
@hannibal002 hannibal002 removed the Soon This Pull Request will be merged within the next couple of betas label Dec 19, 2024
@github-actions github-actions bot added the Detekt Has detekt problem label Dec 19, 2024
@github-actions GitHub Actions
Copy link

One or more Detekt Failures were detected:

@hannibal002 hannibal002 removed this from the Version 0.28 milestone Dec 20, 2024
@CalMWolfs CalMWolfs added this to the Version 0.28 milestone Dec 20, 2024
@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 22, 2024
@CalMWolfs CalMWolfs modified the milestones: Version 0.28, Version 0.29 Dec 22, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 25, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

@hannibal002
Merge branch 'refs/heads/beta' into replace-roman-tests
f006f35 
# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/misc/ReplaceRomanNumerals.kt
@hannibal002
fix merge conflict
654d30a
@github-actions GitHub Actions
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot added Detekt Has detekt problem and removed Merge Conflicts There are open merge conflicts with the beta branch. labels Dec 25, 2024
@github-actions GitHub Actions
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Backend A backend pull request that will be merged soon
Projects
None yet
Milestone
Version 0.29
Development

Successfully merging this pull request may close these issues.
2 participants
@hannibal002 @CalMWolfs