Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: replace roman numeral v2 #3003

Merged
merged 9 commits into from
Dec 19, 2024

Conversation

Mikecraft1224
Copy link
Contributor

@Mikecraft1224 Mikecraft1224 commented Nov 29, 2024

What

Fixed the ReplaceRomanNumeral Feature replacing things it shouldn't. Small changes may follow.

Changelog Fixes

  • Fixed Replace Roman Numerals replacing random letters. - Mikecraft1224

@github-actions github-actions bot added Bug Fix Bug fixes Detekt Has detekt problem labels Nov 29, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 30, 2024
@hannibal002 hannibal002 removed the Bug Fix Bug fixes label Dec 5, 2024
@Mikecraft1224 Mikecraft1224 changed the title Fix replace roman numeralv2 Fix replace roman numeral v2 Dec 5, 2024
@github-actions github-actions bot added the Bug Fix Bug fixes label Dec 5, 2024
@Mikecraft1224 Mikecraft1224 marked this pull request as ready for review December 5, 2024 09:35
@github-actions github-actions bot added the Wrong Title/Changelog There is an error in the title or changelog label Dec 5, 2024
Copy link

github-actions bot commented Dec 5, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Fixed Replace Roman Numerals replacing random letters

Title issues:
PR title does not match the expected format of 'Category: Title'

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 6, 2024
Copy link

github-actions bot commented Dec 6, 2024

One or more Detekt Failures were detected:

@hannibal002 hannibal002 added this to the Version 0.28 milestone Dec 7, 2024
@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 8, 2024
Copy link
Collaborator

@CalMWolfs CalMWolfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make some unit tests for roman numerals so that it is easier to test if it is working as intended

Copy link
Owner

@hannibal002 hannibal002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as my patch in dms: i dont think using regexes is appropriate here, as well as caching is missing. lets discuss

@hannibal002 hannibal002 changed the title Fix replace roman numeral v2 Fix: replace roman numeral v2 Dec 8, 2024
Copy link

github-actions bot commented Dec 8, 2024

I have detected some issues with your pull request:

Body issues:
Change should end with a full stop in text: Fixed Replace Roman Numerals replacing random letters

Please fix these issues. For the correct format, refer to the pull request template.

@github-actions github-actions bot added the Detekt Has detekt problem label Dec 10, 2024
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Dec 10, 2024
@github-actions github-actions bot removed the Wrong Title/Changelog There is an error in the title or changelog label Dec 17, 2024
@hannibal002 hannibal002 merged commit b0b3605 into hannibal002:beta Dec 19, 2024
6 checks passed
@github-actions github-actions bot removed the Bug Fix Bug fixes label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants