Backend: remove deprecated RenderUtils methods #3059
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Backend
One or more Detekt Failures were detected:
|
|
Hello, #3004 alr removes the addItemIcon method |
|
Closing as largely duplicated by above, will reopen as a dependent PR for the |
github-actions
bot
removed
the
Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes deprecated RenderUtils methods
renderSingleLineWithItemsandaddItemIcon, as well as an unused private method in that class. Also remove associated utility method in GardenAPI.Assuming this goes well, I would like to remove the deprecated renderStringsAndItems in a second pass (that one has much broader usage currently, though). I think generally it might be a good idea to only render Renderables and deprecate all other methods rendering lists/strings/etc at Positions, but that can be saved for quite a bit later.
Changelog Technical Details