Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Move Next Jacobs Contest, Best Crop Milestone & Jyrre Timer to Renderable #3004

Merged
merged 13 commits into from
Dec 20, 2024

Conversation

j10a1n15
Copy link
Contributor

@j10a1n15 j10a1n15 commented Nov 29, 2024

What

This Pull Request moves said method to be Renderables, which removes the deprecated addCropIcon method

Changelog Technical Details

  • Moved Next Jacobs Contest, Best Crop Milestone & Jyrre Timer to Renderable. - j10a1n15

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@github-actions github-actions bot added Backend A backend pull request that will be merged soon Detekt Has detekt problem labels Nov 29, 2024
Copy link

One or more Detekt Failures were detected:

Signed-off-by: J10a1n15 <[email protected]>
Copy link

One or more Detekt Failures were detected:

@github-actions github-actions bot removed the Detekt Has detekt problem label Nov 29, 2024
@hannibal002 hannibal002 added this to the Version 0.29 milestone Dec 1, 2024
@j10a1n15 j10a1n15 changed the title Backend: Move Next Jacobs Contest & Best Crop Milestone to Renderable Backend: Move Next Jacobs Contest, Best Crop Milestone & Jyrre Timer to Renderable Dec 5, 2024
@github-actions github-actions bot added the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 14, 2024
Copy link

This pull request has conflicts with the base branch "beta". Please resolve those so we can test out your changes.

# Conflicts:
#	src/main/java/at/hannibal2/skyhanni/features/garden/farming/GardenBestCropTime.kt
Copy link

Conflicts have been resolved! 🎉

@github-actions github-actions bot removed the Merge Conflicts There are open merge conflicts with the beta branch. label Dec 14, 2024
versions/1.8.9/detekt/baseline.xml Outdated Show resolved Hide resolved
src/main/java/at/hannibal2/skyhanni/utils/RenderUtils.kt Outdated Show resolved Hide resolved
i swear im not schizo
trust me
please
i would never

Signed-off-by: J10a1n15 <[email protected]>
Signed-off-by: J10a1n15 <[email protected]>
@j10a1n15 j10a1n15 requested a review from CalMWolfs December 17, 2024 07:53
@hannibal002 hannibal002 merged commit 0d09339 into hannibal002:beta Dec 20, 2024
6 checks passed
@github-actions github-actions bot removed the Backend A backend pull request that will be merged soon label Dec 20, 2024
@CalMWolfs CalMWolfs modified the milestones: Version 0.29, Version 0.28 Dec 20, 2024
@j10a1n15 j10a1n15 deleted the backend/cropicon branch December 20, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants