-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hip: xxx - non interactive nameswaps #3
Conversation
I like this concept. It'll take me some time to read and understand the whole doc before I can comment more. |
I took me a long to time understand how script works. Now it all makes sense to me. Also, I'd like to suggest to create a plugin, extending the
An implementation is not required for a proposal, but it would help a lot its adoption. |
@Falci I have some proof of concept level code that can be found here: https://github.com/tynes/nameswaps/blob/538b98943fe35facd54f7c379f3d4832e68ea796/test/swapsring-test.js#L70 This test shows an example of how a counterparty would verify that the person selling their name is trustworthy. This code is not production ready and needs some major architecture improvements. The project that I was working on was implemented as a plugin for |
Footnote could be used for making the nameswap proofs available. I originally forked the |
OP_ENDIF | ||
``` | ||
|
||
This script could be improved upon and improvements ought to be considered for future versions of this HIP. Improvements include using `OP_CSV` to timeout the swap, enabling the seller to lower |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need this?
After the name is transferred to the script (with no CSV) and finalised, the seller can create the partially signed transaction described here multiple times, with different values.
The seller should keep these TXs in secret, and only reveal the most expensive one. When the seller decides to go for a discount, he/she can release the cheaper TX.
If there's no buyer at all, the seller can do a regular transfer to his/her own address. The only benefit here would be to restore the ability to revoke the name.
Hey there, I've implemented a CLI tool called shakedex that implements this HIP and adds a Dutch auction layer on top using |
``` | ||
OP_TYPE | ||
0x07 // UPDATE | ||
OP_EQUAL | ||
OP_IF | ||
OP_RETURN | ||
OP_ENDIF | ||
OP_TYPE | ||
0x0b // REVOKE | ||
OP_EQUAL | ||
OP_IF | ||
OP_RETURN | ||
OP_ENDIF | ||
OP_TYPE | ||
0x08 // RENEW | ||
OP_EQUAL | ||
OP_IF | ||
OP_RETURN | ||
OP_ENDIF | ||
OP_TYPE | ||
0x09 // TRANSFER | ||
OP_EQUAL | ||
OP_IF | ||
<public key> | ||
OP_CHECKSIGVERIFY | ||
OP_ENDIF | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reccomend a simpler script: see kurumiimari/shakedex#5
OP_TYPE
<int transfer>
OP_EQUAL
OP_IF
<pubkey>
OP_CHECKSIG
OP_ELSE
OP_TYPE
<int finalize>
OP_EQUAL
OP_ENDIF
@Falci I think this should be assigned a HIP number and merged, pending any updates from @tynes. Other users can open PRs that update the protocol (for example my simplified script) The implementation written by @kurumiimari should be included in the HIP notes as well, that is a common attribute of proposals like this and actually I think for example EIP might require an implementation before a proposal is assigned a number. |
Sure @pinheadmz. This is the first HIP 🎉 . |
I'll update with the hip number |
I don't code so i cant understand but let me bring a common man's perspective as what would be a good product in the market. A hub where TLD owners can all pool their TLDs. Different front ends can then sell SLDs for the TLDs using that hub maybe like an API. If the TLD belongs to the company that has created the Front end then the money from the sale of the SLD/TLD goes to the front end with a small facilitation fee for the hub. If the TLD does not belong to the front end company then front end gets a small finders fee and the hub get a small facilitation fee and the rest goes to the actual TLD owner. That way everyone who owns a TLD can gain from this, since not all TLD owners can get into a re-selling business. And Resellers don't need to generate vast resources to buy out everything under the sun. It would be great if a very common payment gateway for fist like CC avenue can be used to accommodate Fiat payments along with crypto payments. The number of people who need and are interested in decentralized TLDs and SLDs will be way more than people with access and interest in crypto in general. Regards :) |
HI @agaamin, Those are interesting suggestions, but SLD is completely out of the scope of this proposal. HIP-5 is closer to that. About payment, the network has it own token ($HNS). At the protocol level, it will only accept HNS, but the app layer could offer more options for the user and convert it to HNS. Again, out of the scope. |
This is a work in progress draft for a non interactive atomic swap based protocol for trading names on a secondary market.
I'd like to fill in more details and get some review from the community.