Fix test failure caused by yargs#1213
Merged
kpdecker merged 1 commit intohandlebars-lang:masterfrom May 17, 2016
jbboehr:hotfix/yargs-check
Merged
Fix test failure caused by yargs#1213kpdecker merged 1 commit intohandlebars-lang:masterfrom jbboehr:hotfix/yargs-check
kpdecker merged 1 commit intohandlebars-lang:masterfrom
jbboehr:hotfix/yargs-check
Conversation
In yargs 3.2, any non-truthy return value to check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000 It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86 It appears the build failed for PR #1180, not sure why it was merged
Contributor
Author
|
@kpdecker This issue is in the master branch, so it's causing the Travis builds for all PRs to fail. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In yargs 3.2, any non-truthy return value from check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000
It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86
It appears the build failed for PR #1180, not sure why it was merged