Use yargs#1180
Conversation
In yargs 3.2, any non-truthy return value to check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000 It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86 It appears the build failed for PR #1180, not sure why it was merged
|
hi all and thanks for making handlebars! I see this more than 3 year old patch but I still have optimist in my dependencies. Did this not make it into the 4.x release at all? |
|
No, @wycats wants a spec before adding new features (#1277) so I am currently only fixing bugs, security issues and make improvements to the build-environment and code cleansiness... I'm not sure if any compability issues arise by using yargs, so I'll not add it in 4.x. I'm trying to move development back to the master-branch, so I may attempt to release 5.0 with the changes on master (#1566) . But I am in no rush. Is there are particular reason why you ask about this? |
I just found this super old dependency in my tree which happens to be pulled in by which appears to be unmaintained for 6 years. My feeling was those should not be in my dependency tree these days. Then I found #1179 and this PR, which were closed/merged so long ago. So yeah, no strictly required but it would be a nice cleanup |
|
I also have optimist in dependencies of handlebars@4.7.3. And now it has vulnerability with minimist. |
|
@serhiyzablotskiy see #1662 for the latest discussion on that topic |
5 participants
Fix #1179