Skip to content
This repository has been archived by the owner on Jul 6, 2019. It is now read-only.

Fixes for rust nightly changes #337

Merged
merged 5 commits into from
Aug 17, 2015
Merged

Conversation

mokus0
Copy link
Contributor

@mokus0 mokus0 commented Aug 16, 2015

As described at rust-lang/rfcs#1184, rustc nightly now automatically imports core when using no_std

@mokus0
Copy link
Contributor Author

mokus0 commented Aug 16, 2015

Working on a few more updates, looks like things have changed even more since the nightly i did this fix for...

@mokus0 mokus0 changed the title Fixes for rust nightly change to behavior of no_std[1] Fixes for rust nightly changes Aug 16, 2015
@mokus0
Copy link
Contributor Author

mokus0 commented Aug 16, 2015

Doesn't build cleanly due to rlibc, and I'm not currently set up to run the full travis test suite, but builds on my system as of today with rustc 1.4.0-nightly (f05b22efb 2015-08-15). There are a few more deprecation and unused-feature warnings, but I'm not 100% on those whether the right thing is to remove them, conditionalize them, or replace them with something else to achieve the same ends.

@farcaller
Copy link
Member

can you please add std::hash::hash fixe there? (see travis)

@farcaller
Copy link
Member

and thanks for getting us back on green again 😄

@mokus0
Copy link
Contributor Author

mokus0 commented Aug 17, 2015

sure, looking into it now

@mcoffin
Copy link
Contributor

mcoffin commented Aug 17, 2015

This will fix #336

@mokus0
Copy link
Contributor Author

mokus0 commented Aug 17, 2015

One more down. Looks like the "core" crate will need to be conditionally included for the "native" build. Gotta get some dinner and put the kids down for bed, but I'll fix that next.

@mokus0
Copy link
Contributor Author

mokus0 commented Aug 17, 2015

Ok, all green :)

farcaller added a commit that referenced this pull request Aug 17, 2015
Fixes for rust nightly changes
@farcaller farcaller merged commit f185eec into hackndev:master Aug 17, 2015
@farcaller
Copy link
Member

Thanks!

@mokus0 mokus0 deleted the nightly-updates branch August 17, 2015 04:53
@mokus0 mokus0 restored the nightly-updates branch August 20, 2015 06:09
@mokus0 mokus0 deleted the nightly-updates branch August 24, 2015 02:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants