Deprecate UnsafeCell::value #25867
Deprecate UnsafeCell::value #25867
Conversation
|
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
|
Nice! Could this actually take the route of |
|
Done. |
petrochenkov
changed the title
| @@ -641,6 +641,8 @@ pub struct UnsafeCell<T: ?Sized> { | |||
| /// | |||
| /// This field should not be accessed directly, it is made public for static | |||
| /// initializers. | |||
| #[deprecated(since = "1.2.0", reason = "use `get` to access the wrapped value or `new` to | |||
There was a problem hiding this comment.
I think this message may be a bit off-kilter due to the newline, could this use \ at the end of the string to make sure it's parsed as one line?
There was a problem hiding this comment.
Also, could you be sure to wrap this line to 80 characters? (the surrounding style)
alexcrichton
added
the
T-libs-api
Now when const functions are implemented and used, the `value` field of `UnsafeCell` can be made deprecated (and then private as intended).
Now when const functions are implemented and used, the
valuefield ofUnsafeCellcan be made deprecated (and then private as intended).